Re: [PATCH v4 1/4] PCI: Introduce pci_dev_for_each_resource()

From: Andy Shevchenko
Date: Tue Mar 14 2023 - 14:41:58 EST


On Fri, Mar 10, 2023 at 03:15:38PM -0700, Keith Busch wrote:
> On Fri, Mar 10, 2023 at 07:14:13PM +0200, Andy Shevchenko wrote:

...

> > +#define pci_dev_for_each_resource_p(dev, res) \
> > + __pci_dev_for_each_resource(dev, res, i, unsigned int)
>
> It looks dangerous to have a macro declare a variable when starting a new
> scope. How do you know the name 'i' won't clash with something defined above?

I'll rename. Thank you.

--
With Best Regards,
Andy Shevchenko