Re: [PATCH net-next v13 11/16] net: dsa: mt7530: use external PCS driver

From: Arınç ÜNAL
Date: Tue Mar 14 2023 - 17:02:03 EST


On 14/03/2023 22:53, Vladimir Oltean wrote:
On Tue, Mar 14, 2023 at 09:21:40PM +0300, Arınç ÜNAL wrote:
I was going to send a mail to netdev mailing list to ask for opinions
whether we should rename the mt7530 DSA driver to mt753x and rename these
functions you mentioned to mt753x so it's crystal clear what code is for
what hardware. Now that we glossed over it here, I guess I can ask it here
instead.

My 2 cents - make your first 100 useful commits on this driver, which at
the very least produce a change in the compiled output, and then go on a
renaming spree as much as you want.

Look, I don't ask for renaming just for the sake of renaming things. I see a benefit which would make things clearer.

If you rather mean to, know the driver very well, by saying do 100 useful commits on the driver beforehand, that makes sense. But I think I'm capable of managing this. I've got the time and energy.

Arınç