Re: [PATCH] p54spi: convert to devicetree

[Arnd Bergmann]

On Wed, Mar 15, 2023, at 07:32, Krzysztof Kozlowski wrote:
> On 14/03/2023 22:40, Arnd Bergmann wrote:
>
>>>> +
>>>> +  power-gpios:
>>>
>>> If this is GPIO driving some power pin, then it should be
>>> "powerdown-gpios" (like in /bindings/gpio/gpio-consumer-common.yaml)
>> 
>> As far as I can tell, it's the opposite: the gpio turns the power on
>> in 'high' state. I could make it GPIO_ACTIVE_LOW and call it powerdown,
>> if you think that's better, but I don't think that is how it was
>> meant.
>
> Whether this is active low or high, I think does not matter. If this is
> pin responsible to control the power, then we use the name
> "powerdown-gpios". Effectively powerup GPIO is the same as powerdown,
> just reversed.

Ok, so should I make this GPIO_ACTIVE_LOW and adapt the patch to
call it powerdown in both the code and dt for consistency?

      Arnd