Re: [PATCH v7 12/13] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver

From: Krzysztof Kozlowski
Date: Wed Mar 15 2023 - 03:45:16 EST


On 14/03/2023 12:55, Vaishnav Achath wrote:
> From: Pratyush Yadav <p.yadav@xxxxxx>
>
> TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate
> capture over a CSI-2 bus. The TI CSI2RX platform driver glues all the
> parts together.
>
> Signed-off-by: Pratyush Yadav <p.yadav@xxxxxx>
> Signed-off-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---


> +$id: http://devicetree.org/schemas/media/ti,j721e-csi2rx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI J721E CSI2RX Wrapper Device Tree Bindings

Drop "Device Tree Bindings"

> +
> +description: |
> + The TI J721E CSI2RX Wrapper is a wrapper around Cadence CSI2RX bridge that
> + enables sending captured frames to memory over PSI-L DMA. In the J721E
> + Technical Reference Manual (SPRUIL1B) it is referred to as "SHIM" under the
> + CSI_RX_IF section.
> +
> +maintainers:
> + - Pratyush Yadav <p.yadav@xxxxxx>
> +
> +properties:
> + compatible:
> + items:

Drop items

> + - const: ti,j721e-csi2rx
> +
> + dmas:
> + maxItems: 1
> +
> + dma-names:
> + items:
> + - const: rx0
> +
> + reg:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + ranges: true
> +
> + "#address-cells": true
> +
> + "#size-cells": true
> +
> +patternProperties:
> + "^csi-bridge@":
> + type: object
> + description: CSI2 bridge node.
> + $ref: cdns,csi2rx.yaml#

Your patch fails here. This error must be fixed or explain as dependency
in the patch changelog. Patch cannot be taken without that dependency.

Best regards,
Krzysztof