Re: [PATCH 04/12] driver core: class: remove module * from class_create()

[Benjamin Tissoires]

On Mar 13 2023, Greg Kroah-Hartman wrote:
> The module pointer in class_create() never actually did anything, and it
> shouldn't have been requred to be set as a parameter even if it did
> something.  So just remove it and fix up all callers of the function in
> the kernel tree at the same time.
> 
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  arch/mips/kernel/mips-mt.c                       | 2 +-
>  arch/mips/sibyte/common/sb_tbprof.c              | 2 +-
>  arch/powerpc/platforms/book3s/vas-api.c          | 2 +-
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c        | 2 +-
>  arch/x86/kernel/cpuid.c                          | 2 +-
>  arch/x86/kernel/msr.c                            | 2 +-
>  block/bsg.c                                      | 2 +-
>  drivers/accel/drm_accel.c                        | 2 +-
>  drivers/accel/habanalabs/common/habanalabs_drv.c | 2 +-
>  drivers/base/power/wakeup_stats.c                | 2 +-
>  drivers/block/aoe/aoechr.c                       | 2 +-
>  drivers/block/rnbd/rnbd-clt-sysfs.c              | 2 +-
>  drivers/block/rnbd/rnbd-srv-sysfs.c              | 2 +-
>  drivers/block/ublk_drv.c                         | 2 +-
>  drivers/char/bsr.c                               | 2 +-
>  drivers/char/dsp56k.c                            | 2 +-
>  drivers/char/ipmi/ipmi_devintf.c                 | 2 +-
>  drivers/char/lp.c                                | 2 +-
>  drivers/char/mem.c                               | 2 +-
>  drivers/char/misc.c                              | 2 +-
>  drivers/char/pcmcia/cm4000_cs.c                  | 2 +-
>  drivers/char/pcmcia/cm4040_cs.c                  | 2 +-
>  drivers/char/pcmcia/scr24x_cs.c                  | 2 +-
>  drivers/char/ppdev.c                             | 2 +-
>  drivers/char/tpm/tpm-interface.c                 | 4 ++--
>  drivers/char/virtio_console.c                    | 2 +-
>  drivers/char/xilinx_hwicap/xilinx_hwicap.c       | 2 +-
>  drivers/char/xillybus/xillybus_class.c           | 2 +-
>  drivers/comedi/comedi_fops.c                     | 2 +-
>  drivers/comedi/drivers/comedi_test.c             | 2 +-
>  drivers/crypto/qat/qat_common/adf_ctl_drv.c      | 2 +-
>  drivers/dca/dca-sysfs.c                          | 2 +-
>  drivers/devfreq/devfreq-event.c                  | 2 +-
>  drivers/devfreq/devfreq.c                        | 2 +-
>  drivers/dma-buf/dma-heap.c                       | 2 +-
>  drivers/extcon/extcon.c                          | 2 +-
>  drivers/fpga/fpga-bridge.c                       | 2 +-
>  drivers/fpga/fpga-mgr.c                          | 2 +-
>  drivers/fpga/fpga-region.c                       | 2 +-
>  drivers/gnss/core.c                              | 2 +-
>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c         | 2 +-
>  drivers/gpu/drm/display/drm_dp_aux_dev.c         | 2 +-
>  drivers/gpu/drm/drm_sysfs.c                      | 2 +-
>  drivers/hid/hid-roccat-arvo.c                    | 2 +-
>  drivers/hid/hid-roccat-isku.c                    | 2 +-
>  drivers/hid/hid-roccat-kone.c                    | 2 +-
>  drivers/hid/hid-roccat-koneplus.c                | 2 +-
>  drivers/hid/hid-roccat-konepure.c                | 2 +-
>  drivers/hid/hid-roccat-kovaplus.c                | 2 +-
>  drivers/hid/hid-roccat-pyra.c                    | 2 +-
>  drivers/hid/hid-roccat-ryos.c                    | 2 +-
>  drivers/hid/hid-roccat-savu.c                    | 2 +-
>  drivers/hid/hidraw.c                             | 2 +-

For the HID part:

Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

Cheers,
Benjamin

[...]