Re: [PATCH 1/8] gpio: ftgpio010: drop of_match_ptr for ID table
From: Bartosz Golaszewski
Date: Wed Mar 15 2023 - 05:40:17 EST
On Sat, Mar 11, 2023 at 12:13 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/gpio/gpio-ftgpio010.c:336:34: error: ‘ftgpio_gpio_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> drivers/gpio/gpio-ftgpio010.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
> index 2728672ef9f8..31e26072f6ae 100644
> --- a/drivers/gpio/gpio-ftgpio010.c
> +++ b/drivers/gpio/gpio-ftgpio010.c
> @@ -349,7 +349,7 @@ static const struct of_device_id ftgpio_gpio_of_match[] = {
> static struct platform_driver ftgpio_gpio_driver = {
> .driver = {
> .name = "ftgpio010-gpio",
> - .of_match_table = of_match_ptr(ftgpio_gpio_of_match),
> + .of_match_table = ftgpio_gpio_of_match,
> },
> .probe = ftgpio_gpio_probe,
> .remove = ftgpio_gpio_remove,
> --
> 2.34.1
>
Applied the series.
Bart