Re: [PATCH v4 26/36] um: Implement the new page table range API

From: Mike Rapoport
Date: Wed Mar 15 2023 - 06:13:17 EST


On Wed, Mar 15, 2023 at 05:14:34AM +0000, Matthew Wilcox (Oracle) wrote:
> Add PFN_PTE_SHIFT and update_mmu_cache_range().
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: linux-um@xxxxxxxxxxxxxxxxxxx

Acked-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>

> ---
> arch/um/include/asm/pgtable.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/um/include/asm/pgtable.h b/arch/um/include/asm/pgtable.h
> index a70d1618eb35..ea5f8122f128 100644
> --- a/arch/um/include/asm/pgtable.h
> +++ b/arch/um/include/asm/pgtable.h
> @@ -242,11 +242,7 @@ static inline void set_pte(pte_t *pteptr, pte_t pteval)
> if(pte_present(*pteptr)) *pteptr = pte_mknewprot(*pteptr);
> }
>
> -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> - pte_t *pteptr, pte_t pteval)
> -{
> - set_pte(pteptr, pteval);
> -}
> +#define PFN_PTE_SHIFT PAGE_SHIFT
>
> #define __HAVE_ARCH_PTE_SAME
> static inline int pte_same(pte_t pte_a, pte_t pte_b)
> @@ -290,6 +286,7 @@ struct mm_struct;
> extern pte_t *virt_to_pte(struct mm_struct *mm, unsigned long addr);
>
> #define update_mmu_cache(vma,address,ptep) do {} while (0)
> +#define update_mmu_cache_range(vma, address, ptep, nr) do {} while (0)
>
> /*
> * Encode/decode swap entries and swap PTEs. Swap PTEs are all PTEs that
> --
> 2.39.2
>
>

--
Sincerely yours,
Mike.