Re: [PATCH] wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()

From: Kalle Valo
Date: Wed Mar 15 2023 - 06:19:25 EST


Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx> wrote:

> Smatch Warns:
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
> warn: missing unwind goto?
>
> Store the error value in ret and use correct label with a goto.
>
> Only Compile tested, found with Smatch.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <error27@xxxxxxxxx>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

488d9a484f96 wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230307104706.240119-1-harshit.m.mogalapalli@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches