Re: next: zip.c:35:8: error: packed attribute causes inefficient alignment for 'magic' [-Werror=attributes]

[Daniel Müller]

On Tue, Mar 14, 2023 at 04:56:15PM -0700, Andrii Nakryiko wrote:
> On Tue, Mar 14, 2023 at 1:01 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Tue, Mar 14, 2023 at 11:52 AM Andrii Nakryiko
> > <andrii.nakryiko@xxxxxxxxx> wrote:
> > >
> > > On Mon, Mar 13, 2023 at 11:38 PM Naresh Kamboju
> > > <naresh.kamboju@xxxxxxxxxx> wrote:
> > > >
> > > > perf builds failing from Linux next-20230307..next-20230314 but pass on
> > > > Linux mainline v6.3-rc2.
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> > >
> > > Thanks for the report, but I'm not sure what's wrong here. We added
> > > __attribute__((packed)) attribute intentionally and want to keep it
> > > this way. It seems like perf itself is using packed structs (e.g.,
> > > struct debug_line_header in util/genelf_debug.c), so I'm wondering why
> > > that code doesn't cause any problems.
> > >
> > > Any hints from perf folks?
> >
> > We use a #pragma to disable the warnings in at least one place:
> > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/lib/perf/include/perf/event.h?h=perf-tools#n194
> >
> 
> Ok, let's do the same here. Daniel, can you please send a follow up
> patch to silence this warning?

Sounds good.

Thanks,
Daniel