Re: [RFC PATCH 3/3] orangefs: use folio in orangefs_readahead()

From: Matthew Wilcox
Date: Wed Mar 15 2023 - 12:06:28 EST


On Wed, Mar 15, 2023 at 01:32:33PM +0100, Pankaj Raghav wrote:
> Use folio and its corresponding function in orangefs_readahead() so that
> folios can be directly passed to the folio_endio().

This is wrong; you need to drop the call to folio_put().

> /* clean up. */
> - while ((page = readahead_page(rac))) {
> - folio_endio(page_folio(page), false, ret);
> - put_page(page);
> + while ((folio = readahead_folio(rac))) {
> + folio_endio(folio, false, ret);
> + folio_put(folio);
> }