Re: [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support

From: Lee Jones
Date: Wed Mar 15 2023 - 13:53:13 EST


On Wed, 15 Mar 2023, Lee Jones wrote:

> On Tue, 07 Mar 2023, Okan Sahin wrote:
>
> > MFD driver for MAX77541/MAX77540 to enable its sub
> > devices.
> >
> > The MAX77541 is a multi-function devices. It includes
> > buck converter and ADC.
> >
> > The MAX77540 is a high-efficiency buck converter
> > with two 3A switching phases.
> >
> > They have same regmap except for ADC part of MAX77541.
> >
> > Signed-off-by: Okan Sahin <okan.sahin@xxxxxxxxxx>
> > ---
> > drivers/mfd/Kconfig | 13 ++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/max77541.c | 224 +++++++++++++++++++++++++++++++++++
> > include/linux/mfd/max77541.h | 97 +++++++++++++++
> > 4 files changed, 335 insertions(+)
> > create mode 100644 drivers/mfd/max77541.c
> > create mode 100644 include/linux/mfd/max77541.h
>
> FYI: I'm not re-reviewing this since you've chosen to ignore some of my
> previous review comments. Issues highlighted by review comments don't
> just go away on resubmission.

... and the subject is malformed.

--
Lee Jones [李琼斯]