Re: [PATCH v19 01/15] splice: Clean up direct_splice_read() a bit

[David Hildenbrand]

On 15.03.23 17:35, David Howells wrote:
> Do a couple of cleanups to direct_splice_read():
>
>   (1) Cast to struct page **, not void *.
>
>   (2) Simplify the calculation of the number of pages to keep/reclaim in
>       direct_splice_read().
>
> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> cc: Jens Axboe <axboe@xxxxxxxxx>
> cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> cc: David Hildenbrand <david@xxxxxxxxxx>
> cc: John Hubbard <jhubbard@xxxxxxxxxx>
> cc: linux-mm@xxxxxxxxx
> cc: linux-block@xxxxxxxxxxxxxxx
> cc: linux-fsdevel@xxxxxxxxxxxxxxx
> ---

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb