[PATCH 3/3] scsi: smartpqi: fix DMA overlapping mappings asymmetry
From: Desnes Nunes
Date: Wed Mar 15 2023 - 15:24:00 EST
Currently, pqi_keep_device_offline() calls pqi_build_raid_path_request()
(i.e., a wrapper to pqi_map_single()), but there isn't a pqi_pci_unmap()
call in pqi_keep_device_offline(). Hence, this is flaged as an API viola-
tion due to the overlapping mapping of the physical address.
This patch fixes following warning:
DMA-API: smartpqi 0000:43:00.0: cacheline tracking EEXIST, overlapping
mappings aren't supported
WARNING: CPU: 0 PID: 15 at kernel/dma/debug.c:570
add_dma_entry+0x1f6/0x2f0
CPU: 0 PID: 15 Comm: kworker/0:1 Not tainted 6.3.0-rc1-linux #1
Call Trace:
<TASK>
dma_map_page_attrs+0x6f/0xa0
pqi_map_single+0xaa/0x160 [smartpqi]
pqi_keep_device_offline+0xaf/0x160 [smartpqi]
? dma_unmap_page_attrs+0x1a1/0x1e0
? pqi_identify_physical_device.constprop.0+0xd3/0xe0 [smartpqi]
pqi_update_scsi_devices+0x284/0x7e0 [smartpqi]
pqi_scan_scsi_devices+0x87/0xe0 [smartpqi]
pqi_ctrl_init+0x725/0xa60 [smartpqi]
pqi_pci_probe+0xa7/0x130 [smartpqi]
local_pci_probe+0x46/0xa0
work_for_cpu_fn+0x16/0x20
process_one_work+0x2bf/0x670
? __pfx_worker_thread+0x10/0x10
worker_thread+0x1d1/0x3b0
? __pfx_worker_thread+0x10/0x10
kthread+0xf3/0x120
? __pfx_kthread+0x10/0x10
ret_from_fork+0x2c/0x50
</TASK>
Fixes: be76f90668d8 ("scsi: smartpqi: Add TEST UNIT READY check for SANITIZE operation")
Signed-off-by: Desnes Nunes <desnesn@xxxxxxxxxx>
---
drivers/scsi/smartpqi/smartpqi_init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 49a8f91810b6..6fca497ca605 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -1726,6 +1726,8 @@ static bool pqi_keep_device_offline(struct pqi_ctrl_info *ctrl_info,
rc = pqi_submit_raid_request_synchronous(ctrl_info, &request.header, 0, &error_info);
+ pqi_pci_unmap(ctrl_info->pci_dev, request.sg_descriptors, 1, dir);
+
if (rc)
goto out; /* Assume not offline */
--
2.39.1