Re: [PATCH] drivers: hwmon: ltc4282: Add support for LTC4282

From: Guenter Roeck
Date: Wed Mar 15 2023 - 17:24:31 EST


On 3/15/23 14:08, Mohammed Danish Ali wrote:
Date: Wed, 15 Mar 2023 20:48:17 +0000

Added support for LTC4282: High Current Hot Swap Controller with I2C
Compatible Monitoring

Signed-off-by: Mohammed Danish Ali <mohammed.danish.ali.14@xxxxxxxxx <mailto:mohammed.danish.ali.14@xxxxxxxxx>>
---

...

+   hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, data, ltc4282_groups);

include/hwmon/hwmon.h:

/*
* hwmon_device_register_with_groups() and
* devm_hwmon_device_register_with_groups() are deprecated.
*/

Documentation/hwmon/submitting-patches.rst:

* Use devm_hwmon_device_register_with_info() or, if your driver needs a remove
function, hwmon_device_register_with_info() to register your driver with the
hwmon subsystem. Try using devm_add_action() instead of a remove function if
possible. Do not use any of the deprecated registration functions.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Please resubmit.

Thanks,
Guenter