Re: [PATCH 5/5] arm64: dts: rockchip: enable rk809 audio codec on the NanoPi R5 series

[Vasily Khoruzhick]

On Wed, Mar 15, 2023 at 9:03 AM Tianling Shen <cnsztl@xxxxxxxxx> wrote:

Hi Tianling,

> +       rk809-sound {

There is no audio jack on my R5S, see [1] and I don't see it on R5C
either, see [2]. I don't see audio output on the pin header either.
How is it supposed to work?

> +               compatible = "simple-audio-card";
> +               simple-audio-card,format = "i2s";
> +               simple-audio-card,name = "Analog RK809";
> +               simple-audio-card,mclk-fs = <256>;
> +
> +               simple-audio-card,cpu {
> +                       sound-dai = <&i2s1_8ch>;
> +               };
> +
> +               simple-audio-card,codec {
> +                       sound-dai = <&rk809>;

It looks like rk809 doesn't have #sound-dai-cells property and it
results in a warning:

arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi:48.27-50.5:
Warning (sound_dai_property): /rk809-sound/simple-audio-card,codec:
Missing property '#sound-dai-cells' in node /i2c@fdd40000/pmic@20 or
bad phandle (referred from sound-dai[0])

Regards,
Vasily

[1] https://wiki.friendlyelec.com/wiki/index.php/NanoPi_R5S
[2] https://wiki.friendlyelec.com/wiki/index.php/NanoPi_R5C