Re: [PATCH v2 2/3] userfaultfd: convert __mcopy_atomic_hugetlb() to use a folio

From: zhangpeng (AS)
Date: Wed Mar 15 2023 - 23:54:43 EST


On 2023/3/16 3:53, Mike Kravetz wrote:

On 03/14/23 13:13, Peng Zhang wrote:
From: ZhangPeng <zhangpeng362@xxxxxxxxxx>

Change copy_huge_page_from_user() to copy_folio_from_user().
Any reason why you did not change copy_user_huge_page to folios as
well? All callers are passing &folio->page.

Just my opinion, but it might be better/easier to review if the copy
routines were done in a separate patch. There is a little more than
folio conversion happening there.

Thanks for your review.

I will change copy_user_huge_page to folios and split this patch in a
v3 of this patch series.

Thanks,
Peng.