Re: [PATCH] net: phy: hisi-festa: Add support for HiSilicon Festa PHYs

[Francois Romieu]

Heiner Kallweit <hkallweit1@xxxxxxxxx> :
> On 17.03.2023 15:30, David Yang wrote:
[...]
> > diff --git a/drivers/net/phy/hisi-festa.c b/drivers/net/phy/hisi-festa.c
> > new file mode 100644
> > index 000000000..ab54ed3ca
> > --- /dev/null
> > +++ b/drivers/net/phy/hisi-festa.c
[...]
> > +static int hisi_festa_patch_fw(struct phy_device *phydev)

This function can fail...

[...]
> > +static int hisi_festa_config_init(struct phy_device *phydev)
> > +{
> > +	hisi_festa_patch_fw(phydev);
> > +	/* ok, use programmed firmware */
> > +	return 0;

... but nobody cares.

This lack of consistency may also be fixed once Heiner's remarks are
answered.

-- 
Ueimor