Re: [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c

From: Mike Rapoport
Date: Sun Mar 19 2023 - 16:52:25 EST


On Sun, Mar 19, 2023 at 08:22:14PM +0000, Matthew Wilcox wrote:
> On Sun, Mar 19, 2023 at 12:07:43PM +0000, Lorenzo Stoakes wrote:
> > On Sun, Mar 19, 2023 at 01:42:14PM +0200, Mike Rapoport wrote:
> > > From: "Mike Rapoport (IBM)" <rppt@xxxxxxxxxx>
> > >
> > > The get_page_from_free_area() helper is only used in mm/page_alloc.c so
> > > move it there to reduce noise in include/linux/mmzone.h
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
>
> > Good catch, I wonder if there are more functions like this that can be dropped
> > from headers?
>
> I don't think anything outside mm/ has any reason to see 'struct
> free_area'. Unfortunately, it's a field in struct zone, so moving
> it out of mmzone.h will be hard (unless we can move struct zone out of
> mmzone.h?)

Seems possible but not trivial.

> free_area_empty() can move to mm/internal.h though

Yes.

--
Sincerely yours,
Mike.