Re: [PATCH v5 0/7] refactor file signing program

From: Shreenidhi Shedi
Date: Mon Mar 20 2023 - 14:57:42 EST


On Tue, 21-Mar-2023 00:13, Shreenidhi Shedi wrote:
From: Shreenidhi Shedi <yesshedi@xxxxxxxxx>

This patch series refactors the sign-file program, like:

- Improve argument parsing logic.
- Add few more easy to remember arguments.
- Add support to sign bunch of modules at once.
- Improve the help message with examples.
- Few trivial checkpatch reported issue fixes.

Version 5 changes:
- Addressed review comments from David Howells.
- Framgmented the patches into further small units.
Link:
v4: https://lore.kernel.org/all/20230221170804.3267242-1-yesshedi@xxxxxxxxx/

Version 1 - Version 4 changes:
Did some back and forth changes. Getting familiar with patch submission
process, nothing significant happened.

Links:
v1: https://lore.kernel.org/all/dc852d8e-816a-0fb2-f50e-ff6c2aa11dd8@xxxxxxxxx/
v2: https://lore.kernel.org/all/20230213185019.56902-1-yesshedi@xxxxxxxxx/
v3: https://lore.kernel.org/all/20230213190034.57097-1-yesshedi@xxxxxxxxx/

Shreenidhi Shedi (7):
sign-file: refactor argument parsing logic - 1
sign-file: refactor argument parsing logic - 2
sign-file: refactor argument parsing logic - 3
sign-file: add support to sign modules in bulk
sign-file: improve help message
sign-file: use const with a global string constant
sign-file: fix do while styling issue

scripts/sign-file.c | 292 +++++++++++++++++++++++++++++++-------------
1 file changed, 209 insertions(+), 83 deletions(-)

--
2.39.2

Hi David,

Please review this change. I missed to add cover letter in my previous mail series. Apologies.

--
Shedi