Re: [PATCH 1/3] arm64: dts: qcom: sc7180-trogdor-pazquel360: drop incorrect RT5682S VBAT-supply
From: Doug Anderson
Date: Wed Mar 22 2023 - 14:15:01 EST
Hi,
On Fri, Feb 17, 2023 at 7:58 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> It seems that the RT5682S codec does not use VBAT-supply:
>
> sc7180-trogdor-pazquel360-lte.dtb: codec@1a: Unevaluated properties are not allowed ('VBAT-supply' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> I don't have access to datasheet. Driver still requests VBAT-supply but
> other boards simply remove this property for RT5682S.
I checked and I don't see the driver requesting VBAT. Specifically
note that this is the "s" variant which seems to share no code with
the old variants (the "i" variant and the SDW variant).
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi | 1 +
> 1 file changed, 1 insertion(+)
This seems right to me.
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>