Re: [PATCH v3 6/6] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info

[Chester Lin]

Hi Andy,

Thanks for reviewing this patch!

On Thu, Mar 23, 2023 at 08:50:41PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 23, 2023 at 4:49 PM Chester Lin <clin@xxxxxxxx> wrote:
> >
> > The .data field in struct of_device_id is used as a const member so it's
> > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > because some members in s32_pinctrl_soc_info need to be filled by
> > pinctrl-s32cc at runtime.
> >
> > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > to represent const .data in of_device_id. To combine these two structures,
> > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> 
> So, the first patch has to be embedded in this one, correct?

Correct. Leave the first patch alone will cause a compiler warning.

> Don't forget to compile and test your contributions beforehand.

Will do.

Regards,
Chester

> 
> -- 
> With Best Regards,
> Andy Shevchenko