Re: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support

From: Herbert Xu
Date: Fri Mar 24 2023 - 05:46:05 EST


On Mon, Mar 13, 2023 at 09:56:46PM +0800, Jia Jie Ho wrote:
>
> +static void starfive_hash_dma_callback(void *param)
> +{
> + struct starfive_cryp_dev *cryp = param;
> +
> + complete(&cryp->tx_comp);
> +}

Please get rid of tx_comp and do the rest of the processing here.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt