Re: [PATCH] drm/bridge: ps8640: Return NULL immediately when EDID read fail

From: Doug Anderson
Date: Fri Mar 24 2023 - 10:01:53 EST


Hi,

On Thu, Mar 23, 2023 at 8:59 PM Pin-yen Lin <treapking@xxxxxxxxxxxx> wrote:
>
> drm_edid_read returns NULL on error, so feeding it directly into
> drm_edid_duplicate may lead to NULL pointer dereference. Add a check to
> guard this.
>
> Fixes: 6a17b4d1b52f ("drm/bridge: ps8640: Add a cache for EDID")
> Signed-off-by: Pin-yen Lin <treapking@xxxxxxxxxxxx>
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 6 ++++++
> 1 file changed, 6 insertions(+)

Given that the other patch just landed and this is a straightforward
fix, I'm not doing the customary "delay" before landing and I've
pushed this to drm-misc-next:

14aed8ea48e2 drm/bridge: ps8640: Return NULL immediately when EDID read fail

If someone else had extra feedback on this it could always be handled
in a followon patch.

-Doug