Re: [PATCH] iio: adc: mt6370: Fix ibus and ibat scaling value of some specific vendor ID chips
From: kernel test robot
Date: Fri Mar 24 2023 - 12:14:37 EST
Hi ChiaEn,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.3-rc3 next-20230324]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/ChiaEn-Wu/iio-adc-mt6370-Fix-ibus-and-ibat-scaling-value-of-some-specific-vendor-ID-chips/20230324-221545
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/1679667167-16261-1-git-send-email-chiaen_wu%40richtek.com
patch subject: [PATCH] iio: adc: mt6370: Fix ibus and ibat scaling value of some specific vendor ID chips
config: riscv-randconfig-r034-20230324 (https://download.01.org/0day-ci/archive/20230325/202303250050.V7JLIADZ-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/9822359d5de2dba531d882cfee6949864a2d6170
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review ChiaEn-Wu/iio-adc-mt6370-Fix-ibus-and-ibat-scaling-value-of-some-specific-vendor-ID-chips/20230324-221545
git checkout 9822359d5de2dba531d882cfee6949864a2d6170
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/iio/adc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303250050.V7JLIADZ-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/iio/adc/mt6370-adc.c:306:31: warning: variable 'priv' is uninitialized when used here [-Wuninitialized]
ret = mt6370_get_vendor_info(priv);
^~~~
drivers/iio/adc/mt6370-adc.c:297:30: note: initialize the variable 'priv' to silence this warning
struct mt6370_adc_data *priv;
^
= NULL
1 warning generated.
vim +/priv +306 drivers/iio/adc/mt6370-adc.c
293
294 static int mt6370_adc_probe(struct platform_device *pdev)
295 {
296 struct device *dev = &pdev->dev;
297 struct mt6370_adc_data *priv;
298 struct iio_dev *indio_dev;
299 struct regmap *regmap;
300 int ret;
301
302 regmap = dev_get_regmap(pdev->dev.parent, NULL);
303 if (!regmap)
304 return dev_err_probe(dev, -ENODEV, "Failed to get regmap\n");
305
> 306 ret = mt6370_get_vendor_info(priv);
307 if (ret)
308 return dev_err_probe(dev, ret, "Failed to get vid\n");
309
310 indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
311 if (!indio_dev)
312 return -ENOMEM;
313
314 priv = iio_priv(indio_dev);
315 priv->dev = dev;
316 priv->regmap = regmap;
317 mutex_init(&priv->adc_lock);
318
319 ret = regmap_write(priv->regmap, MT6370_REG_CHG_ADC, 0);
320 if (ret)
321 return dev_err_probe(dev, ret, "Failed to reset ADC\n");
322
323 indio_dev->name = "mt6370-adc";
324 indio_dev->info = &mt6370_adc_iio_info;
325 indio_dev->modes = INDIO_DIRECT_MODE;
326 indio_dev->channels = mt6370_adc_channels;
327 indio_dev->num_channels = ARRAY_SIZE(mt6370_adc_channels);
328
329 return devm_iio_device_register(dev, indio_dev);
330 }
331
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests