Re: [PATCH] mtd: rawnand: stm32_fmc2: do not support EDO mode

[Christophe Kerello]

Hello Miquel,

On 3/24/23 17:25, Miquel Raynal wrote:
> Hi Christophe,
>
> christophe.kerello@xxxxxxxxxxx wrote on Fri, 24 Mar 2023 17:09:18 +0100:
>
> > FMC2 controller does not support EDO mode (timings mode 4 and 5).
> >
> > Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver")
> > ---
> >   drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > index 5d627048c420..3abb63d00a0b 100644
> > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> > @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr,
> >   	if (IS_ERR(sdrt))
> >   		return PTR_ERR(sdrt);
> >   
> > +	if (sdrt->tRC_min < 30000)
>
> When introducing NV-DDR support we as well added a timings.mode field,
> perhaps you could use it?

Yes, I can use it. It will be done in V2.

Regards,
Christophe Kerello.

> > +		return -EOPNOTSUPP;
> > +
> >   	if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)
> >   		return 0;
> >   
>
>
> Thanks,
> Miquèl