Re: [RESEND PATCH] staging: most: fix line ending with '(' in video

[Ira Weiny]

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the function parameters right after the '(' in the function call
> line.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@xxxxxxxxx>
> ---
>  drivers/staging/most/video/video.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index ffa97ef21ea5..6254a5df2502 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
>  
>  /**************************************************************************/
>  
> -static struct most_video_dev *get_comp_dev(
> -	struct most_interface *iface, int channel_idx)
> +static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)

I know the 80 char limit is not strictly enforced anymore but I, and some
other maintainers, like to see it adhered to unless there is a really good
reason to violate it.  How about?

static struct most_video_dev *get_comp_dev(struct most_interface *iface,
					   int channel_idx)

Ira

>  {
>  	struct most_video_dev *mdev;
>  	unsigned long flags;
> -- 
> 2.34.1
> 
>