Re: [PATCH] ksmbd: remove unused is_char_allowed function

From: Sergey Senozhatsky
Date: Fri Mar 24 2023 - 21:20:51 EST


On (23/03/24 13:30), Tom Rix wrote:
>
> clang with W=1 reports
> fs/ksmbd/unicode.c:122:19: error: unused function
> 'is_char_allowed' [-Werror,-Wunused-function]
> static inline int is_char_allowed(char *ch)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Reviewed-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>

We have a copy of that function in fs/ksmbd/misc.c.