Re: [PATCH v2] crypto - img-hash: Depend on OF and silence compile test warning

From: Herbert Xu
Date: Sat Mar 25 2023 - 01:59:51 EST


On Fri, Mar 24, 2023 at 11:51:43AM +0100, Krzysztof Kozlowski wrote:
>
> > You should either add a dependency on OF or __maybe_unused.
> > Adding both makes no sense.
>
> Of course it makes, otherwise you have warnings which is also fixed here.

It won't create a warning if you depend on OF without COMPILE_TEST.

Anyway, I think adding __maybe_unused by itself is sufficient.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt