Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device
From: Mark Brown
Date: Sat Mar 25 2023 - 14:05:51 EST
On Sun, Mar 26, 2023 at 01:26:55AM +0800, Ye, Xiang wrote:
> On Sat, Mar 25, 2023 at 05:20:09PM +0100, Greg Kroah-Hartman wrote:
> > As this requires ACPI, why are you not saying so in your Kconfig entry?
> I would add a `depends on ACPI` item on the Kconfig entry so that the
> CONFI_ACPI macro can be removed from usb-ljca, because our use case with
> LJCA currently needs the ACPI binding.
> > What good would this driver be without ACPI enabled?
> Before, I just tried to make it compatible with other platforms that
> don't support ACPI but want to use LJCA device. But, We don't have
> this use case until now.
If it builds without ACPI then making the dependency ACPI ||
COMPILE_TEST will help improve build coverage for people doing
treewide or subsystem work.
Attachment:
signature.asc
Description: PGP signature