Re: [PATCH] rcu: torture: ppc: Remove duplicated argument --enable-kvm

From: Paul E. McKenney
Date: Sun Mar 26 2023 - 11:09:04 EST


On Sun, Mar 26, 2023 at 08:24:34AM +0800, zhouzhouyi@xxxxxxxxx wrote:
> From: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>
>
> The argument --enable-kvm is duplicated because qemu_args
> in kvm-test-1-run.sh has already give this.
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>

Good catch! Applied, thank you!

Thanx, Paul

> ---
> Dear RCU and PPC developers
>
> I discover this possible minor flaw when I am performing RCU torture
> test in PPC VM of of Open Source Lab of Oregon State University.
>
> But I can't test my patch because I am in a VM.
>
> Thanks for your time
>
> Cheers ;-)
> Zhouyi
> --
> tools/testing/selftests/rcutorture/bin/functions.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/rcutorture/bin/functions.sh b/tools/testing/selftests/rcutorture/bin/functions.sh
> index b52d5069563c..48b9147e8c91 100644
> --- a/tools/testing/selftests/rcutorture/bin/functions.sh
> +++ b/tools/testing/selftests/rcutorture/bin/functions.sh
> @@ -250,7 +250,7 @@ identify_qemu_args () {
> echo -machine virt,gic-version=host -cpu host
> ;;
> qemu-system-ppc64)
> - echo -enable-kvm -M pseries -nodefaults
> + echo -M pseries -nodefaults
> echo -device spapr-vscsi
> if test -n "$TORTURE_QEMU_INTERACTIVE" -a -n "$TORTURE_QEMU_MAC"
> then
> --
> 2.34.1
>