RE: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master

[Ping-Ke Shih]

> -----Original Message-----
> From: Cai Huoqing <cai.huoqing@xxxxxxxxx>
> Sent: Thursday, March 23, 2023 7:26 PM
> To: cai.huoqing@xxxxxxxxx
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Yan-Hsuan Chuang
> <tony0620emma@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>; ath10k@xxxxxxxxxxxxxxxxxxx;
> linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> ath11k@xxxxxxxxxxxxxxxxxxx; ath12k@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
> 
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
>         u16 pci_command;
> 
>         pci_read_config_word(dev, PCI_COMMAND, &pci_command);
>         if (pci_command & PCI_COMMAND_MASTER) {
>                 pci_command &= ~PCI_COMMAND_MASTER;
>                 pci_write_config_word(dev, PCI_COMMAND, pci_command);
>         }
> 
>         pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
>  drivers/net/wireless/realtek/rtw89/pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
> index ec8bb5f10482..75bd3ac4dd71 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.c
> +++ b/drivers/net/wireless/realtek/rtw89/pci.c
> @@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev,
>  static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,
>                                      struct pci_dev *pdev)
>  {
> -       pci_clear_master(pdev);
>         pci_disable_device(pdev);
>  }
> 
> --
> 2.34.1