Re: [PATCH v2 2/3] dt-bindings: arm: Add Coresight Dummy Trace YAML schema

From: Hao Zhang
Date: Mon Mar 27 2023 - 01:59:07 EST


Hi Suzuki,

On 3/24/2023 6:47 PM, Suzuki K Poulose wrote:
On 24/03/2023 06:16, Hao Zhang wrote:
Add new coresight-dummy.yaml file describing the bindings required
to define coresight dummy trace in the device trees.

Signed-off-by: Hao Zhang <quic_hazha@xxxxxxxxxxx>
---
  .../bindings/arm/qcom,coresight-dummy.yaml    | 118 ++++++++++++++++++
  1 file changed, 118 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/arm/qcom,coresight-dummy.yaml

diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-dummy.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-dummy.yaml
new file mode 100644
index 000000000000..7b719b084d72
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/qcom,coresight-dummy.yaml
@@ -0,0 +1,118 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+# Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/qcom,coresight-dummy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: QCOM Coresight Dummy component

As mentioned in the previous email, please make this Arm CoreSight. This
is not specific to Qcom, rather something the CoreSight driver exposes
as a dummy framework. Otherwise looks good to me.

Suzuki


Thanks for your comment, I will take your advice and update it in the next version of patch.

Thanks,
Hao