Re: [PATCH -next 2/2] spi: sprd: Use devm_platform_get_and_ioremap_resource()

[Baolin Wang]

On 3/27/2023 2:05 PM, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

> ---
>   drivers/spi/spi-sprd.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c
> index 702acaeebab2..518c7eaca84e 100644
> --- a/drivers/spi/spi-sprd.c
> +++ b/drivers/spi/spi-sprd.c
> @@ -929,8 +929,7 @@ static int sprd_spi_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	ss = spi_controller_get_devdata(sctlr);
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ss->base = devm_ioremap_resource(&pdev->dev, res);
> +	ss->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(ss->base)) {
>   		ret = PTR_ERR(ss->base);
>   		goto free_controller;