Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support

From: Jarrah
Date: Mon Mar 27 2023 - 03:55:42 EST


Hi Javier,

On 3/27/23 18:41, Javier Martinez Canillas wrote:
From: Ondrej Jirman <megi@xxxxxx>

The phone's display is using a Hannstar LCD panel. Support it by adding a
panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).

Signed-off-by: Ondrej Jirman <megi@xxxxxx>
Co-developed-by: Martijn Braam <martijn@xxxxxxxxx>
Co-developed-by: Kamil Trzciński <ayufan@xxxxxxxxx>
Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
---

Changes in v2:
- Drop touchscreen node because used the wrong compatible (Ondrej Jirman).


Any reason not to include this with the correct compatible string? It's been available since https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/. Swapping out gt917s for gt1158 in the node from your previous patch should be enough.

Thanks,

Jarrah.