Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support

[Jarrah]

On 3/27/23 20:11, Heiko Stübner wrote:
> Am Montag, 27. März 2023, 09:55:15 CEST schrieb Jarrah:
> > Hi Javier,
> >
> > On 3/27/23 18:41, Javier Martinez Canillas wrote:
> > > From: Ondrej Jirman <megi@xxxxxx>
> > >
> > > The phone's display is using a Hannstar LCD panel. Support it by adding a
> > > panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc).
> > >
> > > Signed-off-by: Ondrej Jirman <megi@xxxxxx>
> > > Co-developed-by: Martijn Braam <martijn@xxxxxxxxx>
> > > Co-developed-by: Kamil Trzciński <ayufan@xxxxxxxxx>
> > > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> > > ---
> > >
> > > Changes in v2:
> > > - Drop touchscreen node because used the wrong compatible (Ondrej Jirman).
> >
> > Any reason not to include this with the correct compatible string? It's
> > been available since
> > https://lore.kernel.org/all/20220813043821.9981-1-kernel@undef.tools/.
> > Swapping out gt917s for gt1158 in the node from your previous patch
> > should be enough.
> Just wondering if I'm blind, Javier's patch doesn't contain any touchscreen
> controller (haven't found neither gt9* or gt11* mentioned there), so
> I'm inclined to go with the "touchscreen can be added later" thing.


I was just commenting on the "Changes in v2" section. v1 had a 
touchscreen node in it (assuming I found the right v1).


All good, I can follow up with a patch for the touchscreen.