Re: [git pull] common helper for kmap_local_page() users in local filesystems

[Fabio M. De Francesco]

On sabato 11 marzo 2023 18:11:01 CEST Fabio M. De Francesco wrote:
> On venerdì 10 marzo 2023 21:44:31 CET Al Viro wrote:
> > 	kmap_local_page() conversions in local filesystems keep running into
> > 
> > kunmap_local_page()+put_page() combinations; we can keep inventing names
> > for identical inline helpers, but it's getting rather inconvenient.  I've
> > added a trivial helper to linux/highmem.h instead.
> 
> Yeah, "put_and_unmap_page()". Nice helper :-)

[snip]

Hi Al, 

> Why did you name it "put_and_unmap_page()" instead of 
"unmap_and_put_page()",
> for we always unmap first _and_ put the page immediately the unmapping?
>
> It seems it want to imply that instead we put first and unmap later (which
> would be wrong). That name sounds misleading to me and not sound (logically
> speaking).
> 
> Am I missing some obscure convention behind your choice of that name for the
> helper?

Can you please explain what I'm missing behind your motivation?

Thanks,

Fabio

P.S.: Adding Ira to the Cc list, since he's been doing kmap() and 
kmap_atomic() conversions long time before I too started with them.