[PATCH net-next v2 1/4] mptcp: avoid unneeded address copy

From: Matthieu Baerts
Date: Mon Mar 27 2023 - 06:24:36 EST


From: Paolo Abeni <pabeni@xxxxxxxxxx>

In the syn_recv fallback path, the msk is unused. We can skip
setting the socket address.

Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>
Signed-off-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>
---
net/mptcp/subflow.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index dadaf85db720..a11f4c525e01 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -821,8 +821,6 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
goto dispose_child;
}

- if (new_msk)
- mptcp_copy_inaddrs(new_msk, child);
mptcp_subflow_drop_ctx(child);
goto out;
}

--
2.39.2