Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

[Pavel Machek]

Hi!

> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual
> Flash LED current sources, a RGB LED driver, a backlight WLED driver,
> a display bias driver and a general LDO for portable devices.
> 
> Add support for the MediaTek MT6370 Current Sink Type LED Indicator
> driver. It can control four channels current-sink RGB LEDs with 3 modes:
> constant current, PWM, and breath mode.
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> Co-developed-by: Alice Chen <alice_chen@xxxxxxxxxxx>
> Signed-off-by: Alice Chen <alice_chen@xxxxxxxxxxx>
> Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> Signed-off-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx>


> +++ b/drivers/leds/rgb/Makefile
> @@ -2,3 +2,4 @@
>  
>  obj-$(CONFIG_LEDS_PWM_MULTICOLOR)	+= leds-pwm-multicolor.o
>  obj-$(CONFIG_LEDS_QCOM_LPG)		+= leds-qcom-lpg.o
> +obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370-rgb.o

I'd preffer leds-mt6370 name. We already have "rgb" in directory
name...

Otherwise looks good. Thanks for doing this.

BR,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature