Re: [PATCH] iio: tsl2772: remove unused prox_diode_mask variable

From: Andy Shevchenko
Date: Mon Mar 27 2023 - 09:07:57 EST


On Mon, Mar 27, 2023 at 08:08:23AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/iio/light/tsl2772.c:576:24: error: variable
> 'prox_diode_mask' set but not used [-Werror,-Wunused-but-set-variable]
> int i, ret, num_leds, prox_diode_mask;
> ^
> This variable is not used so remove it.

While from the compilation point of view this is a correct fix, I think
we need to hear from the author (or interested stakeholders) about this
feature. Perhaps it should be enabled / fixed differently.

--
With Best Regards,
Andy Shevchenko