Re: [PATCH v2] arm64: dts: rk3399-pinephone-pro: Add internal display support

From: Javier Martinez Canillas
Date: Mon Mar 27 2023 - 11:40:55 EST


Ondřej Jirman <megi@xxxxxx> writes:

Hell Ondřej,

> Hi Javier,
>
> I've tried the patch on top of linus/master and it works as expected. My
> DRM test app shows 16.669ms between frames. The display output is ok on
> developer batch pinephone pro, and is corrupted on production version.
> Display also doesn't come back after blanking. All as expected.
>
> Tested-by: Ondrej Jirman <megi@xxxxxx>
>

Thanks for testing.

> A few more comments below.
>

I'm OK with these comments but I did a git diff with your orange-pi-6.3
branch just before posting and this was the latest that's in your tree.

So feel free to either post a v3 addressing the things you are pointing
out or lets land this and we can post any further cleanups on top IMO.

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat