Re: [PATCH -next] spi: xilinx: Use devm_platform_get_and_ioremap_resource()

[Michal Simek]

On 3/28/23 08:15, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
>   drivers/spi/spi-xilinx.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 5dd3d1901412..8e6e3876aa9a 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -440,8 +440,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
>          xspi->bitbang.txrx_bufs = xilinx_spi_txrx_bufs;
>          init_completion(&xspi->done);
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       xspi->regs = devm_ioremap_resource(&pdev->dev, res);
> +       xspi->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(xspi->regs))
>                  return PTR_ERR(xspi->regs);
>
> --
> 2.20.1.7.g153144c

Reviewed-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal