Re: [RFC 1/2] ARM: dts: omap: Drop ti,omap36xx compatible

From: Andreas Kemnade
Date: Tue Mar 28 2023 - 03:06:30 EST


On Tue, 28 Mar 2023 08:01:15 +0300
Tony Lindgren <tony@xxxxxxxxxxx> wrote:

> * Andreas Kemnade <andreas@xxxxxxxxxxxx> [230327 19:18]:
> > On Thu, 16 Feb 2023 09:33:38 -0600
> > Andrew Davis <afd@xxxxxx> wrote:
> >
> > > This was not matched anywhere and provides no additional information.
> > >
> > > Signed-off-by: Andrew Davis <afd@xxxxxx>
> > > ---
> > > arch/arm/boot/dts/omap3-beagle-xm.dts | 2 +-
> > > arch/arm/boot/dts/omap3-cm-t3730.dts | 2 +-
> > > arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 2 +-
> > > arch/arm/boot/dts/omap3-igep0020.dts | 2 +-
> > > arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 2 +-
> > > arch/arm/boot/dts/omap3-igep0030.dts | 2 +-
> > > arch/arm/boot/dts/omap3-lilly-dbb056.dts | 2 +-
> > > arch/arm/boot/dts/omap3-n9.dts | 2 +-
> > > arch/arm/boot/dts/omap3-n950.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-alto35.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-chestnut43.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-gallop43.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-palo35.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-palo43.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-summit.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-tobi.dts | 2 +-
> > > arch/arm/boot/dts/omap3-overo-storm-tobiduo.dts | 2 +-
> > > arch/arm/boot/dts/omap3-pandora-1ghz.dts | 2 +-
> > > arch/arm/boot/dts/omap3-sbc-t3730.dts | 2 +-
> > > arch/arm/boot/dts/omap3-sniper.dts | 2 +-
> > > arch/arm/boot/dts/omap3-zoom3.dts | 2 +-
> > > 21 files changed, 21 insertions(+), 21 deletions(-)
> > >
> > hmm, we have
> > drivers/clk/ti/dpll.c: of_machine_is_compatible("ti,omap36xx"))
> >
> > but that is more completely
> > if ((of_machine_is_compatible("ti,omap3630") ||
> > of_machine_is_compatible("ti,omap36xx")) &&
> >
> > so missing omap36xx will not harm if 3630 is there. SO this should
> > be probably ok.
>
> Looks like we still have these that should be patched away first:
>
> drivers/cpufreq/ti-cpufreq.c- { .compatible = "ti,omap34xx", .data = &omap34xx_soc_data, },
> drivers/cpufreq/ti-cpufreq.c: { .compatible = "ti,omap36xx", .data = &omap36xx_soc_data, },
>
seen that but there is also
{ .compatible = "ti,omap3430", .data = &omap34xx_soc_data, },
{ .compatible = "ti,omap3630", .data = &omap36xx_soc_data, },

so, no trouble will appear when omap36xx is removed.

Regards,
Andreas