Re: [PATCH v2] clk: add missing of_node_put() in "assigned-clocks" property parsing

From: Clément Léger
Date: Tue Mar 28 2023 - 03:46:17 EST


Le Tue, 14 Mar 2023 17:44:35 -0700,
Stephen Boyd <sboyd@xxxxxxxxxx> a écrit :

> Quoting Clément Léger (2023-01-31 00:32:27)
> > When returning from of_parse_phandle_with_args(), the np member of the
> > of_phandle_args structure should be put after usage. Add missing
> > of_node_put() calls in both __set_clk_parents() and __set_clk_rates().
> >
> > Fixes: 86be408bfbd8 ("clk: Support for clock parents and rates assigned from device tree")
> > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx>
> > ---
>
> Does this series from a year ago help[1]?
>
> [1] https://lore.kernel.org/all/20220623121857.886-1-nuno.sa@xxxxxxxxxx/
>
> Nobody reviewed it, but if you can then I can probably apply it.

I'm only be able to review the first patch of the serie which
is equivalent to what I did but it mixes refactoring and fixes.

--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com