Re: [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support

[Andy Shevchenko]

On Tue, Mar 28, 2023 at 08:26:41AM +0000, Sahin, Okan wrote:
> >On Wed, 15 Mar 2023, Lee Jones wrote:
> >> On Tue, 07 Mar 2023, Okan Sahin wrote:

...

> For previous patch(v5), There was feedback from Andy. I did not fix them. 

Why not? :-)

> 1) 
> > They have same regmap except for ADC part of MAX77541.
> 
> Extra space in the Subject.
> 
> ...
> 
> > +#include <linux/of_device.h
> 
> This is my fault, I missed this comment. I will fix in following patch(v7).
> 
> 2)
> ...
> 
> > +static const struct regmap_config max77541_regmap_config = {
> > +	.reg_bits   = 8,
> > +	.val_bits   = 8,
> 
> Do you need lock of regmap?
> 
> > +};
> 
> ...
> 
> Since I do not need lock of regmap, I did not change anything in
> regmap_config (v6). Do I need to answer this question even if I don't need
> lock of regmap?

IIRC the lock is opt-out. You need to explicitly disable it if not needed.

-- 
With Best Regards,
Andy Shevchenko