Re: [PATCH 2/2] dt-bindings: pinctrl: mediatek: deprecate custom bias pull properties for mt8365

[AngeloGioacchino Del Regno]

Il 28/03/23 15:06, Alexandre Mergnat ha scritto:
> In order to be more generic, "mediatek,pull-up-adv" and
> "mediatek,pull-down-adv" should be deprecated. Use "bias-pull-up" and
> "bias-pull-down" instead.
>
> Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
> ---
>   .../bindings/pinctrl/mediatek,mt8365-pinctrl.yaml  | 32 +++++++++++++++++++---
>   1 file changed, 28 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml
> index 347f533776ba..4ebc7f1caf55 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml
> @@ -72,12 +72,32 @@ patternProperties:
>             bias-disable: true
>   
>             bias-pull-up:
> +            oneOf:
> +              - type: boolean
> +              - enum: [0, 1, 2, 3]
> +                description: Pull up R1/R0 type define value.
>               description: |
> -              Besides generic pinconfig options, it can be used as the pull up
> -              settings for 2 pull resistors, R0 and R1. User can configure those
> -              special pins.
> +              For pull up type is normal, it don't need add R1/R0 define.
> +              For pull up type is R1/R0 type, it can add value to set different
> +              resistance. Valid arguments are described as below:
> +              0: (R1, R0) = (0, 0) which means R1 disabled and R0 disabled.
> +              1: (R1, R0) = (0, 1) which means R1 disabled and R0 enabled.
> +              2: (R1, R0) = (1, 0) which means R1 enabled and R0 disabled.
> +              3: (R1, R0) = (1, 1) which means R1 enabled and R0 enabled.
>   
> -          bias-pull-down: true
> +          bias-pull-down:
> +            oneOf:
> +              - type: boolean
> +              - enum: [0, 1, 2, 3]
> +                description: Pull down R1/R0 type define value.
> +            description: |
> +              For pull down type is normal, it don't need add R1/R0 define.
> +              For pull down type is R1/R0 type, it can add value to set
> +              different resistance. Valid arguments are described as below:
> +              0: (R1, R0) = (0, 0) which means R1 disabled and R0 disabled.
> +              1: (R1, R0) = (0, 1) which means R1 disabled and R0 enabled.
> +              2: (R1, R0) = (1, 0) which means R1 enabled and R0 disabled.
> +              3: (R1, R0) = (1, 1) which means R1 enabled and R0 enabled.
>   
>             input-enable: true
>   
> @@ -123,7 +143,9 @@ patternProperties:
>               enum: [0, 1, 2, 3, 4, 5, 6, 7]
>   
>             mediatek,pull-up-adv:
> +            deprecated: true

Same for this one, removing it shouldn't be a ABI breakage.... but please wait
for Krzysztof or Rob to confirm that before pushing a v2.