Re: [PATCH v2 0/3] xen/netback: fix issue introduced recently

From: Jan Beulich
Date: Tue Mar 28 2023 - 09:57:20 EST


On 28.03.2023 15:52, Paolo Abeni wrote:
> On Tue, 2023-03-28 at 15:10 +0200, Juergen Gross wrote:
>> The fix for XSA-423 introduced a bug which resulted in loss of network
>> connection in some configurations.
>>
>> The first patch is fixing the issue, while the second one is removing
>> a test which isn't needed. The third patch is making error messages
>> more uniform.
>>
>> Changes in V2:
>> - add patch 3
>> - comment addressed (patch 1)
>
> I misread the thread on v2 as the build_bug_on() was not needed and
> applied such revision. 

I guess it's not the end of the world if we go forward without that extra
check. It's a safeguard for theoretical future work which, as Jürgen says,
isn't very likely to occur anyway.

Jan