Re: [PATCH] ARM: dts: stm32: add FMC support on STM32MP13x SoC family

[Christophe Kerello]

Hello Krzysztof,

On 3/28/23 16:53, Krzysztof Kozlowski wrote:
> On 28/03/2023 14:26, Christophe Kerello wrote:
> > This patch adds the FMC support on STM32MP13x SoC family.
>
> Do not use "This commit/patch", but imperative mood. See:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> > Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/stm32mp131.dtsi | 34 +++++++++++++++++++++++++++++++
> >   1 file changed, 34 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
> > index 5949473cbbfd..7af3eb15c204 100644
> > --- a/arch/arm/boot/dts/stm32mp131.dtsi
> > +++ b/arch/arm/boot/dts/stm32mp131.dtsi
> > @@ -1137,6 +1137,40 @@ mdma: dma-controller@58000000 {
> >   			dma-requests = <48>;
> >   		};
> >   
> > +		fmc: memory-controller@58002000 {
> > +			#address-cells = <2>;
> > +			#size-cells = <1>;
> > +			compatible = "st,stm32mp1-fmc2-ebi";
> > +			reg = <0x58002000 0x1000>;
>
>
> compatible is first, reg is second. ranges if present should be third.

Ok, it will be done in V2.

Regards,
Christophe Kerello.

> > +			clocks = <&rcc FMC_K>;
> > +			resets = <&rcc FMC_R>;
> > +			status = "disabled";
> > +
> > +			ranges = <0 0 0x60000000 0x04000000>, /* EBI CS 1 */
>
> Best regards,
> Krzysztof