Re: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table

From: Stefan Schmidt
Date: Tue Mar 28 2023 - 12:14:17 EST


Hello.

On 28.03.23 12:48, Miquel Raynal wrote:
Hi Krzysztof,

krzysztof.kozlowski@xxxxxxxxxx wrote on Sat, 11 Mar 2023 18:32:58 +0100:

The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).

drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

I see Stefan already acked most of the ieee802154 patches, but I didn't
got notified for this one, so in case:

The reason I did not ack the two patches for adf7242 is that Michael as driver maintainer ack'ed them already.

I only handled the ones where we have no active maintainer, as a fallback.

regards
Stefan Schmidt