Re: [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()

From: Logan Gunthorpe
Date: Tue Mar 28 2023 - 13:36:30 EST




On 2023-03-28 11:34, Bjorn Helgaas wrote:
> On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
>> Remove pci_p2pmem_dma() reference,
>> because pci_p2pmem_dma() method is already removed.
>
> AFAICT, pci_p2pmem_dma() *never* existed. I suppose it was a typo,
> and pci_p2pdma_distance_many() was intended?
>
> I'm happy to either merge this patch (with an updated commit log) to
> remove the comment text or merge a patch correct the comment text.
>
> I just don't want to merge this with a commit log that says we removed
> the pci_p2pmem_dma() method when it never actually existed.

Ah, yes that's fair. I thought pci_p2pmem_dma() was an odd function
name. Good to confirm it never existed.

Thanks,

Logan