[PATCH v1 2/6] perf report: Additional config warnings

From: Ian Rogers
Date: Tue Mar 28 2023 - 19:56:51 EST


If the default_sort_order isn't correctly strdup-ed warn and return an
error. Debug warn if no option is matched.

Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
tools/perf/builtin-report.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 6400615b5e98..500f9d8902e7 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -143,6 +143,10 @@ static int report__config(const char *var, const char *value, void *cb)

if (!strcmp(var, "report.sort_order")) {
default_sort_order = strdup(value);
+ if (!default_sort_order) {
+ pr_err("Not enough memory for report.sort_order\n");
+ return -1;
+ }
return 0;
}

@@ -151,6 +155,7 @@ static int report__config(const char *var, const char *value, void *cb)
return 0;
}

+ pr_debug("%s variable unknown, ignoring...", var);
return 0;
}

--
2.40.0.348.gf938b09366-goog